Add a machine e2e test to test connection to host.containers.internal#29115
Draft
l0rd wants to merge 2 commits into
Draft
Add a machine e2e test to test connection to host.containers.internal#29115l0rd wants to merge 2 commits into
host.containers.internal#29115l0rd wants to merge 2 commits into
Conversation
The lookup for the gvproxy process was broken on Windows: - We looked for gvproxy, not gvproxy.exe, and `tasklist` was always failing - But `pgrep` wasn't failing because we looked for the wrong `tasklist` error message (the correct error message on my laptop is "INFO: No tasks are running which match the specified criteria.") - WSL uses win-sshproxy.exe, not gvproxy.exe Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
l0rd
force-pushed
the
wsl-host-containers-internal-test
branch
from
e2f4ffe to
2e807f2
Compare
Add one more test to the basic podman commands e2e tests: - starts an HTTP server on the host - verify HTTP requests from a container, using `host.containers.internal` or `host.docker.internal`, are routed successfully to the server running on the host Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
l0rd
force-pushed
the
wsl-host-containers-internal-test
branch
from
2e807f2 to
db3b18b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to podman-container-tools/container-libs#959: keeping this PR as a draft until we have a WSL image with the fix
The original issue #28477
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?