[draft/DNM] GHA CI nits#2885
Draft
kolyshkin wants to merge 3 commits into
Draft
Conversation
It it not needed; actions/checkout already does this. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Since commit 7d3c3ce ("Makefile: set GOBIN") GOBIN is set to /bin (because "go env GOBIN" usually returns an empty string, and $(GOPATH) is not ever set), which is terribly wrong. This was worked around in .cirrus.yml, and now also in .github/workflows/ci.yml. Remove the GHA workaround, fix it in Makefile. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
mtrmac
reviewed
Jun 2, 2026
mtrmac
left a comment
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
(ACK to the concept of both — the safe.directory thing was also bothering me but we didn’t take the time to figure out why it was necessary.)
|
A friendly reminder that this PR had no activity for 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.