inspect: add Comment field to inspect output#2890
Conversation
Expose the Comment field from the image configuration in the skopeo inspect JSON output. Previously, the Comment field was available via 'podman inspect' but not via 'skopeo inspect'. Closes podman-container-tools#2098 Signed-off-by: ATULSHARMA1234 <143108076+ATULSHARMA1234@users.noreply.github.com>
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks for the PR!
In a curious coincidence, another PR for this was submitted very recently: #2884 and the review comments there apply here as well — note also the pointer to an earlier review.
This one differs in patching the vendor tree — that’s closer but we can’t be maintaining a separate fork. Please submit that as a separate PR to https://github.com/podman-container-tools/container-libs .
(I did not substantially review the code in the vendored parts, this is not a design approval of the semantics.)
|
@ATULSHARMA1234 are you able to make the necessary changes in the container-libs project for this? |
@ATULSHARMA1234 ping ^ |
4 participants
Expose the Comment field from the image configuration in the skopeo inspect JSON output. Previously, the Comment field was available via 'podman inspect' but not via 'skopeo inspect'.
Closes #2098