ci: make the automation release renovate managed#2911
Merged
Conversation
Member
Author
|
OMG, using the env block as part of an image name is not supported https://github.com/orgs/community/discussions/26324 |
Put the variable in the workflow file like the renovate config expects, see podman-container-tools/automation#29 Now using ${{ env.AUTOMATION_RELEASE }} inside the container image name would have been way to simple and obvious so GitHub decided that this does not work and the work around for that seems to be run another job and convert the value into an output... Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Contributor
|
fyi. |
We have a new config in the automation repo under podman-container-tools, see podman-container-tools/automation#29 Fixes: podman-container-tools#2912 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
Author
ah yes thanks, forgot about it |
10 tasks
Contributor
|
this LGTM |
mtrmac
approved these changes
Jul 15, 2026
mtrmac
left a comment
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
The extra step to convert an env into output is a… clever trick.
| # For some reason github decided that using ${{ env }} is not valid inside a container image name. | ||
| # As such we must work around this, using outputs there is valid so we need this job to convert the | ||
| # env into an output. Since we already have the path-filter job we might as well reuse it. | ||
| - name: set AUTOMATION_RELEASE output |
Contributor
There was a problem hiding this comment.
(Absolutely non-blocking: Starting with a capital letter here would be more consistent with what other actions do.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the variable in the workflow file like the renovate config expects, see podman-container-tools/automation#29