Skip to content

refactor: Move scan parameter parsing for parquet to reusable function #23019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented May 30, 2025

Eventually should allow us to de-duplicate a lot of parameter parsing logic across scan types as well as supporting more parameters for them.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 30, 2025
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (e8ef72f) to head (0aba5c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23019      +/-   ##
==========================================
+ Coverage   80.38%   80.41%   +0.02%     
==========================================
  Files        1682     1682              
  Lines      223374   223291      -83     
  Branches     2803     2802       -1     
==========================================
- Hits       179560   179551       -9     
+ Misses      43147    43077      -70     
+ Partials      667      663       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nameexhaustion nameexhaustion changed the title refactor: Move scan parameter parsing for parquet to unified location refactor: Move scan parameter parsing for parquet to reusable function May 30, 2025
@nameexhaustion nameexhaustion marked this pull request as ready for review May 31, 2025 05:07
@nameexhaustion nameexhaustion marked this pull request as draft May 31, 2025 09:06
@nameexhaustion nameexhaustion marked this pull request as ready for review May 31, 2025 09:06
@nameexhaustion nameexhaustion marked this pull request as draft May 31, 2025 09:13
@nameexhaustion nameexhaustion marked this pull request as ready for review May 31, 2025 09:34
@nameexhaustion nameexhaustion marked this pull request as draft May 31, 2025 16:00
@nameexhaustion nameexhaustion marked this pull request as ready for review June 1, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant