Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/checkout-update-race #4884

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Fix/checkout-update-race #4884

merged 2 commits into from
Jan 23, 2025

Conversation

frankie567
Copy link
Member

Prevent accidental update while confirmation is pending

@frankie567 frankie567 enabled auto-merge (rebase) January 23, 2025 15:36
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
polar ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 3:36pm
polar-sandbox ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 3:36pm

Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 154.8 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seventy-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/_not-found/page 353 B 155.15 KB 44.33% (+/- <0.01%)
/checkout/[clientSecret]/confirmation/page 277.31 KB 432.11 KB 123.46% (+/- <0.01%)
/(main)/verify-email/page 352 B 155.15 KB 44.33% (+/- <0.01%)
/(main)/(installation)/github/layout 352 B 155.15 KB 44.33% (+/- <0.01%)
/(main)/(topbar)/layout 241.57 KB 396.37 KB 113.25% (+/- <0.01%)
/(main)/[organization]/(header)/issues/page 122.35 KB 277.16 KB 79.19% (+/- <0.01%)
/(main)/[organization]/(header)/layout 275.5 KB 430.3 KB 122.94% (+/- <0.01%)
/(main)/[organization]/(header)/page 134.34 KB 289.14 KB 82.61% (+/- <0.01%)
/(main)/[organization]/(header)/subscriptions/page 353 B 155.15 KB 44.33% (+/- <0.01%)
/(main)/[organization]/[repo]/issues/[number]/status/page 228.27 KB 383.08 KB 109.45% (+/- <0.01%)
/(main)/[organization]/[repo]/layout 230.39 KB 385.2 KB 110.06% (+/- <0.01%)
/(main)/[organization]/[repo]/issues/[number]/(create)/page 199.63 KB 354.43 KB 101.27% (+/- <0.01%)
/(main)/[organization]/[repo]/page 204.61 KB 359.41 KB 102.69% (+/- <0.01%)
/(main)/[organization]/portal/page 220.34 KB 375.15 KB 107.19% (+/- <0.01%)
/(main)/backoffice/badge/page 44.24 KB 199.05 KB 56.87% (+/- <0.01%)
/(main)/backoffice/layout 257.27 KB 412.07 KB 117.74% (+/- <0.01%)
/(main)/backoffice/pledges/page 56.63 KB 211.43 KB 60.41% (+/- <0.01%)
/(main)/backoffice/issue/[id]/page 54.38 KB 209.18 KB 59.77% (+/- <0.01%)
/(main)/backoffice/rewards_pending/page 58.47 KB 213.28 KB 60.94% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/file-downloads/page 175.14 KB 329.95 KB 94.27% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/license-keys/page 87.91 KB 242.71 KB 69.35% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/products/[id]/page 193.34 KB 348.15 KB 99.47% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/products/page 86.99 KB 241.8 KB 69.09% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/subscriptions/[id]/page 216.03 KB 370.84 KB 105.95% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/subscriptions/page 89.53 KB 244.34 KB 69.81% (+/- <0.01%)
/(main)/(topbar)/(backer)/settings/page 260.41 KB 415.22 KB 118.63% (+/- <0.01%)
/(main)/[organization]/portal/(topbar)/authenticate/page 73.17 KB 227.97 KB 65.13% (+/- <0.01%)
/(main)/[organization]/portal/(topbar)/subscriptions/[id]/page 213.61 KB 368.41 KB 105.26% (+/- <0.01%)
/(main)/[organization]/portal/(topbar)/orders/[id]/page 193.24 KB 348.05 KB 99.44% (+/- <0.01%)
/(main)/[organization]/portal/(topbar)/request/page 68.92 KB 223.72 KB 63.92% (+/- <0.01%)
/(main)/dashboard/(create)/create/page 156.46 KB 311.27 KB 88.93% (+/- <0.01%)
/(main)/dashboard/(create)/layout 354 B 155.15 KB 44.33% (+/- <0.01%)
/(main)/(landing)/(mdx)/layout 353 B 155.15 KB 44.33% (+/- <0.01%)
/(main)/dashboard/[organization]/storefront/page 381.37 KB 536.17 KB 153.19% (+/- <0.01%)
/(main)/dashboard/[organization]/layout 46.68 KB 201.49 KB 57.57% (+/- <0.01%)
/(main)/(topbar)/(backer)/(sidebar)/funding/page 252.51 KB 407.32 KB 116.38% (+/- <0.01%)
/(main)/(topbar)/(backer)/(sidebar)/layout 138.71 KB 293.51 KB 83.86% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/incoming/page 233.25 KB 388.06 KB 110.87% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/layout 212.77 KB 367.57 KB 105.02% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/account/page 201.88 KB 356.68 KB 101.91% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/outgoing/page 182.91 KB 337.71 KB 96.49% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/rewards/page 117.63 KB 272.43 KB 77.84% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/(home)/page 339.46 KB 494.27 KB 141.22% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/page 354 B 155.15 KB 44.33% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/layout 257.26 KB 412.07 KB 117.73% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/analytics/page 389.32 KB 544.12 KB 155.46% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/benefits/license-keys/page 291.28 KB 446.08 KB 127.45% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/benefits/page 359.44 KB 514.24 KB 146.93% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/customers/page 293.13 KB 447.93 KB 127.98% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/customers/[id]/page 389.48 KB 544.29 KB 155.51% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/initialize/page 141.97 KB 296.78 KB 84.79% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/issues/badge/page 286.67 KB 441.47 KB 126.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/issues/organizations/page 259.89 KB 414.7 KB 118.48% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/issues/embed/page 259.88 KB 414.68 KB 118.48% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/issues/overview/page 302.27 KB 457.07 KB 130.59% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/meters/[slug]/page 429.66 KB 584.46 KB 166.99% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/members/page 258.22 KB 413.03 KB 118.01% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/benefits/page 358.96 KB 513.76 KB 146.79% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/meters/page 289.86 KB 444.67 KB 127.05% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/[id]/page 355.28 KB 510.08 KB 145.74% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/discounts/page 320.66 KB 475.47 KB 135.85% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/new/page 346.86 KB 501.66 KB 143.33% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/sales/[id]/page 305.23 KB 460.03 KB 131.44% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/products/page 352 B 155.15 KB 44.33% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/page 295.67 KB 450.48 KB 128.71% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/sales/page 301.18 KB 455.98 KB 130.28% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/settings/custom-fields/page 299.11 KB 453.91 KB 129.69% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/settings/webhooks/endpoints/[id]/page 296.51 KB 451.32 KB 128.95% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/settings/webhooks/page 278.53 KB 433.33 KB 123.81% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/settings/page 278.89 KB 433.69 KB 123.91% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/account/page 150.05 KB 304.85 KB 87.10% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/layout 257.27 KB 412.07 KB 117.74% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/incoming/page 181.26 KB 336.07 KB 96.02% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/outgoing/page 130.83 KB 285.64 KB 81.61% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/contributors/page 65.48 KB 220.28 KB 62.94% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/layout 257.27 KB 412.07 KB 117.74% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/rewarded/page 65.47 KB 220.28 KB 62.94% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/page 66.2 KB 221 KB 63.14% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@frankie567 frankie567 merged commit 5a9ac37 into main Jan 23, 2025
11 checks passed
@frankie567 frankie567 deleted the fix/checkout-update-race branch January 23, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant