Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checkout Link state issues #4939

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Conversation

birkjernstrom
Copy link
Member

  • clients: Fix Checkout Link state issue with discounts
  • clients: Fix Checkout Link state issue with success_url

Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 8:31pm
polar-sandbox 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 8:31pm

Copy link
Contributor

github-actions bot commented Feb 1, 2025

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 154.81 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/(main)/dashboard/[organization]/(header)/products/[id]/checkout-links/page 354.19 KB 509 KB 145.43% (🟡 +0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/contributors/page 156.69 KB 311.5 KB 89.00% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/rewarded/page 156.69 KB 311.5 KB 89.00% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@birkjernstrom birkjernstrom merged commit 2fb5aea into main Feb 1, 2025
9 of 12 checks passed
@birkjernstrom birkjernstrom deleted the fix/checkout-link-state branch February 1, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant