Skip to content

organization_access_token: Add SANDBOX_ to tokens when in sandbox env #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

malthejorgensen
Copy link
Contributor

@malthejorgensen malthejorgensen commented Jul 1, 2025

Tested with tokens created inside and outside of sandbox, both on main.

  • Token created on main ("before this change") works on this branch ✅
  • Token created on this branch works on this branch ✅

Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 0:46am
polar-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 0:46am

Copy link
Contributor

github-actions bot commented Jul 1, 2025

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 157.31 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Does the same for personal access tokens, but those are deprecated and
thus no longer being created (but are potentially still in use by
customers).
# that.
# The prefix is listed here for later reference.
#
# TOKEN_PREFIX = "polar_pat_"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing comment 👍

@frankie567
Copy link
Member

frankie567 commented Jul 4, 2025

LGTM!

Edit: we can do the special error message when detecting a sandbox prefix in production in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants