Skip to content

137 feature add parser to generate json files for arcplc projections #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

ylyangtw
Copy link
Contributor

@ylyangtw ylyangtw commented Feb 17, 2025

  • Separated current and proposed data into 2 json files
  • Included Median to results

@ylyangtw ylyangtw linked an issue Feb 17, 2025 that may be closed by this pull request
@ylyangtw ylyangtw marked this pull request as draft February 17, 2025 16:28
@ylyangtw ylyangtw marked this pull request as ready for review February 18, 2025 19:04
@navarroc
Copy link

We need to better understand the base acre calculation. If you look at the 2024 base acres excel file, county Autauga, AL only has 1361 acres enrolled in ARC-CO and 83.91 acres for Corn. So the result in our JSON file should be something in the ballpark of those numbers, but the JSON has 53016000.0 acres enrolled in PLC. We need to dig deeper into Henrique's code to understand how he's determining the split. Our numbers for a county should not vary too far from the 2024 numbers.

@ylyangtw
Copy link
Contributor Author

We need to better understand the base acre calculation. If you look at the 2024 base acres excel file, county Autauga, AL only has 1361 acres enrolled in ARC-CO and 83.91 acres for Corn. So the result in our JSON file should be something in the ballpark of those numbers, but the JSON has 53016000.0 acres enrolled in PLC. We need to dig deeper into Henrique's code to understand how he's determining the split. Our numbers for a county should not vary too far from the 2024 numbers.

Ah ok, I will look into it

@sandeep-ps
Copy link
Member

sandeep-ps commented Mar 14, 2025

The proposed payments JSON.gz file need to be added to this PR. Thanks.

@sandeep-ps
Copy link
Member

sandeep-ps commented Mar 14, 2025

We have been using the main.py file to call the individual parsers to keep things simple. I understand that some parsers still need to be added to this file, but it would be good to call the ArcPlcParser from the main.py as well. Thanks.

@sandeep-ps
Copy link
Member

sandeep-ps commented Mar 14, 2025

After consulting with the research team, if there are no concerns with uploading the raw CSV file, I think we should upload it to the repository. The maximum file size is at least 2 GB. So, we are good there.

Let's wait until we get confirmation from the research team.

@sandeep-ps
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add parser to generate JSON files for ARC/PLC projections
3 participants