Skip to content

Snap map refactoring #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 17, 2025
Merged

Snap map refactoring #398

merged 8 commits into from
Jul 17, 2025

Conversation

ylyangtw
Copy link
Contributor

@ylyangtw ylyangtw commented Jul 8, 2025

Waiting for dev database update

Copy link
Collaborator

@pengyin-shan pengyin-shan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ylyangtw, there are some linting errors that need to be addressed in this PR. You can start by running npm run lint -- --fix to apply automatic fixes, and then manually resolve any remaining issues.

@ylyangtw
Copy link
Contributor Author

ylyangtw commented Jul 8, 2025

Hi @ylyangtw, there are some linting errors that need to be addressed in this PR. You can start by running npm run lint -- --fix to apply automatic fixes, and then manually resolve any remaining issues.

Thanks Pengyin! It's been addressed.

Copy link
Collaborator

@pengyin-shan pengyin-shan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running this PR locally, found the following:

  1. The tooltip padding needs adjustment. Please refer to the tooltips on other maps for the correct padding:
Screenshot 2025-07-08 at 11 39 24 AM
  1. We also want the Avg. Monthly Participation to be part of tooltip, as what we are currrently having in the dev:
Screenshot 2025-07-08 at 11 43 37 AM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we’re no longer using summary, could you check where this data endpoint or variable is used and remove any related references?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pengyin! I have addressed all of them

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Just a very minor thing: I noticed that the tooltip arrow is showing a slightly different color in the dev environment compared to the rest of the tooltip. It looks like the main background color is a bit lighter than expected:
Screenshot 2025-07-14 at 2 06 04 PM

Can you check to see why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I have addressed it

@ylyangtw ylyangtw linked an issue Jul 10, 2025 that may be closed by this pull request
Copy link
Collaborator

@pengyin-shan pengyin-shan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked dev and it looks good now. Approving this PR

Copy link
Contributor

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally vs dev and everything looks good. Tested downloading the graph, verifying the table data and tooltips for a few states.

@ylyangtw ylyangtw merged commit fd20546 into develop Jul 17, 2025
5 checks passed
@ylyangtw ylyangtw deleted the SNAP-map-refactoring branch July 17, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Refactor SNAP map
3 participants