Cleaning up some code and adding more suspend (removing most runBlocking) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-green-to-grey Changes unread marker in item_room.xml
…_realm_usages Improve usage of realm
…ent-android-element-app Translations update from Weblate
…ash-at-registration element-hq#5218: Fix crash at registration when redirecting to Web View
…_1_4_2 Weblate 1 4 2
`readReceiptsSummaryEntity.realm` is null
…ctions/michaelkaye/matrix-hookshot-action-0.3.0 Bump michaelkaye/matrix-hookshot-action from 0.2.0 to 0.3.0
Sync analytics plan
…KeysBackupPasswordTest ignore KeysBackup tests
Fix Media cache size with negative values in the General Settings screen
…l-library-version Upgrades to Material 1.5.0 (dependency only)
…ctions/actions/setup-python-3 Bump actions/setup-python from 2 to 3
* separating the debug overrides to their own abstraction - rather than sharing the user facing vector data store * inlining the debug flow getters and declarations - also replaces funs with vals as the references are immutable * adding changelog entry
…sts_logcat Nightly Tests should save logcat logs to artifact
* adding base choose name fragment with UI * add click handling for the display name actions * updating real account display name * setting the initial disabled state when the view is created * adding header padding which would have been a toolbar * exiting the flow on display name updated or skipped, the next PR will introduce the profile picture screen * updating view model state testing to take all emissions into account * adding tests around the onboarding view model - cases for the personalisation and display name actions * using colorSecondary instead of accent as per quality script rule * making use of viewevent delegating action for the back handling * using debounced clicks * consuming the back action when existing the display name fragment via viewmodel * making the keyboard imeDone update the display name
…removing unused VectorDatastore
…mpilation-error Fixing unit test compilation error
…om.google.android.gms-oss-licenses-plugin-0.10.5 Bump oss-licenses-plugin from 0.10.4 to 0.10.5 - REQUIRE HUMAN INTERVENTION
…-allowed-depenency-groups Adding missing dependency allowances
Override task affinity to prevent unknown activities running in our app tasks.
…into rust_upstream_develop
Rust upstream develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a big one: