Making opts.cwd persist through chained calls#17
Open
brynbellomy wants to merge 3 commits intopolotek:masterfrom
brynbellomy:master
Open
Making opts.cwd persist through chained calls#17brynbellomy wants to merge 3 commits intopolotek:masterfrom brynbellomy:master
brynbellomy wants to merge 3 commits intopolotek:masterfrom
brynbellomy:master
Conversation
Owner
|
Hey it look like this is failing travis tests. I haven't had a chance to look over it yet. But can you look into that? |
|
It seems travis's problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically what the title says. I really didn't want to barf all over your implementation, which is really elegant and concise, so I took as much care as I could in not adding unnecessary fields to objects, not repeating anything, etc. However, I did have to make a second call to
normalizeArguments(), but to balance that out, I modifiedprocSteam()so that the first argument could be an object containing the already-normalized argument fields. In this case, the call tonormalizeArguments()is not made inside ofprocStreams()-- no code is actually run twice. It was the best workaround I could think of without doing some fundamental rewriting.Let me know if you have a better idea about how to implement this -- I'm all ears.