Install default config file, set Pop-like keyboard shortcuts #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drakulix
approved these changes
Apr 11, 2022
| (modifiers: [Logo], key: "h"): Orientation(Horizontal), | ||
| (modifiers: [Ctrl], key: "Return"): Spawn("gnome-terminal"), | ||
| (modifiers: [Logo], key: "o"): Orientation(Horizontal), | ||
| //TODO: ability to select default web browser |
There was a problem hiding this comment.
Note, that this will likely be done by a matching portal implementation eventually anyway.
Either the portal will bind some default shell-keys itself or e.g. cosmic-launcher will request this particular set of key bindings through a portal.
See discussion of global hotkeys on wayland:
- https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/56
- Global keyboard shortcut portal flatpak/xdg-desktop-portal#624
- Add a global shortcut portal flatpak/xdg-desktop-portal#711
The sets of apps provided here are a good start though. 👍
There was a problem hiding this comment.
That sounds good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure config.ron is installed at /etc/cosmic-comp/config.ron in the debian packaging, and sets the default shortcuts to ones closer to those used on Pop. There are some TODOs in the updated config file to indicate what needs to be done to better match Pop's current shortcuts.