toplevel-info: Fix race between binding wl_ouput and output_enter
#668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with `cosmic-panel` where, when a workspace is moved back to an output after a monitor is disconnected and reconnected, the panel doesn't hide because `cosmic-panel` thinks no toplevel is open on that monitor. After some testing, it seems `output_enter` isn't being sent here. In particular, the `output_leave` call happens before the client binds the `wl_output`, so there is no `wl_output` to send in an event yet. This is addressed by keeping track of a set of `wl_output`s that we have sent the event to. So if an output is bound, `refresh` can add it to this list and send the event. This is not needed for workspaces (though it could be done similarly) since the handle objects are created by server events. So no race should occur as long as the workspaces global is bound before the toplevel info one.
wash2
approved these changes
Jul 31, 2024
Drakulix
approved these changes
Aug 1, 2024
ids1024
added a commit
that referenced
this pull request
Jan 27, 2025
#668 previously did this for toplevel events, but missed the fact that the workspaces protocol has the same issue. Fixes pop-os/cosmic-workspaces-epoch#61.
ids1024
added a commit
that referenced
this pull request
Jan 27, 2025
#668 previously did this for toplevel events, but missed the fact that the workspaces protocol has the same issue. Fixes pop-os/cosmic-workspaces-epoch#61.
ids1024
added a commit
that referenced
this pull request
Jan 27, 2025
#668 previously did this for toplevel events, but missed the fact that the workspaces protocol has the same issue. Fixes pop-os/cosmic-workspaces-epoch#61.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
cosmic-panelwhere, when a workspace is moved back to an output after a monitor is disconnected and reconnected, the panel doesn't hide becausecosmic-panelthinks no toplevel is open on that monitor.After some testing, it seems
output_enterisn't being sent here. In particular, theoutput_leavecall happens before the client binds thewl_output, so there is nowl_outputto send in an event yet.This is addressed by keeping track of a set of
wl_outputs that we have sent the event to. So if an output is bound,refreshcan add it to this list and send the event.This is not needed for workspaces (though it could be done similarly) since the handle objects are created by server events. So no race should occur as long as the workspaces global is bound before the toplevel info one.