fix: Window opening on dual screen #1183

[LinuxHeki]

I have no idea what I changed, but now is working perfectly!

[jackpot51]

It looks reasonable to me. @mmstick what do you think?

[jackpot51]

I would recommend squashing this into one commit, though

[LinuxHeki]

How to squash this into one commit?

[LinuxHeki]

Do I need to delete repo, fork this repo and make changes in one commit?

[mmstick]

git reset --soft 130ac4f
git commit --amend

As long as QA is okay with the window attaching to the display that the mouse is on, regardless of which window is actively focused. Because GNOME always opens the window on the display where the mouse is.

[LinuxHeki]

Is this what I needed to do?

[LinuxHeki]

Or do I need to do this with every commit?

[mmstick]

Now you have more commits rather than less

[LinuxHeki]

Sorry

[LinuxHeki]

So what do I need to do? More precisely please. I'm 14.

[isantop]

I believe you can get what is needed with the following:

git fetch
git reset --soft origin/master
git add .
git commit --amend
git push -f

[LinuxHeki]

After git add . I typed git status and nothing shows up. Is this right?

[isantop]

Nope, you should be seeing the files you modified. What are your remotes looking like?

git remote -v

[LinuxHeki]

origin https://github.com/LinuxHeki/shell (fetch) origin https://github.com/LinuxHeki/shell (push) upstream https://github.com/pop-os/shell.git (fetch) upstream https://github.com/pop-os/shell.git (push)

[isantop]

I see the issue. You need to do as follows:

git fetch upstream
git reset --soft upstream/master
git add .
git commit --amend
git push -f -u origin master

[LinuxHeki]

Why are in the commit changes that I didn't do?

[isantop]

It looks like those are the changes to our local master branch which you had previously merged in as a merge commit. It shouldn't be a problem, provided the Engineering review still checks out.

[jacobgkau]

The description for the commit is talking about the Flatpak fix and not what this commit's actually doing.

[jacobgkau]

I squashed the commits from earlier into the correct starting commit and force-pushed. The metadata should be correct now, will test soon.

[LinuxHeki]

So, that's it?

[jacobgkau]

After building this locally to test, this doesn't seem to fix #1183:

simplescreenrecorder-2021-10-14_15.34.02.mp4

At first, I thought it was because of the mouse position behavior that @mmstick described, but I also recreated it where the window gets fullscreened onto a display the mouse isn't on:

simplescreenrecorder-2021-10-14_15.38.54.mp4

[LinuxHeki]

Is working, except if there are more than two windows on second display and zero on main, then Minecraft 1.17 moves to main display. Minecraft 1.8 moves to main display every single time.

Fix is not perfect but it's better than nothing (for me).

How are your videos long 30s and less than 10MB and mine 15s and 15MB?

[LinuxHeki]

Now should work with Minecraft 1.17 but not with Minecraft 1.8

[jacobgkau]

Now should work with Minecraft 1.17 but not with Minecraft 1.8

I'm still not seeing any change in behavior, still testing with Minecraft 1.17 since it's the latest version:

The window and cursor were both on the primary display, then Minecraft full-screened itself to the external display. We're wanting it to full-screen onto the same display it's currently on, correct?

[LinuxHeki]

If you press F11 three times is working...

[mmstick]

The only change this makes is reverting 49aba22

[LinuxHeki]

Yes...

[mmstick]

Commit was reverted, so we can close this