Skip to content

Wallpaper additions#13

Open
Schykle wants to merge 21 commits intopop-os:masterfrom
Schykle:master
Open

Wallpaper additions#13
Schykle wants to merge 21 commits intopop-os:masterfrom
Schykle:master

Conversation

@Schykle
Copy link
Copy Markdown
Contributor

@Schykle Schykle commented May 8, 2020

Added another image, taken today by me. Under CC BY 4.0

Schykle added 21 commits May 3, 2020 23:31
Couldn't figure out how to rename the original uploads, so I've reuploaded as a separate process with proper file names. (Apologies for the inconvenience.)
Added four wallpapers using naming conventions already in place, such as hyphens and lowercase. Also, because I didn't know how to edit file names for files already uploaded, sorry.
File too large.
These files are intended to replace my original uploads to address concerns of file sizes being too large. The previous file sizes of 15MB+ per file are now reduced to ~4MB without sacrificing image quality. I apologize for the mistake.
@Schykle
Copy link
Copy Markdown
Contributor Author

Schykle commented May 8, 2020

Changes made to original files to reduce size while retaining quality to address concerns expressed in #12

@Schykle Schykle changed the title Added another WP Wallpaper additions May 8, 2020
@leviport leviport linked an issue May 11, 2020 that may be closed by this pull request
@leviport leviport requested review from a team and jackpot51 May 11, 2020 15:04
Copy link
Copy Markdown
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also adds a new wallpaper on top of reducing the size of the 4 previously added, but it looks good. For future reference, it's probably better to have fixes and new additions in separate PRs.

@jackpot51
Copy link
Copy Markdown
Member

Squashed and merged into master with this commit: 4115ea6

By squashing it with the previous PR the compression is now used in GIT history

@jackpot51 jackpot51 closed this May 14, 2020
@jackpot51 jackpot51 reopened this May 14, 2020
@jackpot51
Copy link
Copy Markdown
Member

We've decided to move community contributed wallpapers to another package for easier maintenance. I will let you know when that is ready

@erwinwallpaper
Copy link
Copy Markdown

Good Job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New wallpapers are large!

4 participants