Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to_string_hex_array string reserve #1619

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Fix to_string_hex_array string reserve #1619

merged 1 commit into from
Dec 2, 2023

Conversation

htotoo
Copy link
Member

@htotoo htotoo commented Dec 2, 2023

Since we will create 2 chars from each uint8_t, reserve space for all.

NotherNgineer
NotherNgineer approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@NotherNgineer NotherNgineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotherNgineer NotherNgineer merged commit 4f44005 into portapack-mayhem:next Dec 2, 2023
@htotoo htotoo deleted the stringopt branch December 2, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotherNgineer NotherNgineer NotherNgineer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htotoo @NotherNgineer