Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve BLE RX app settings across runs, and changed BLE app settings file names #1622

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Preserve BLE RX app settings across runs, and changed BLE app settings file names #1622

merged 3 commits into from
Dec 4, 2023

Conversation

NotherNgineer
Copy link
Contributor

  1. Preserving the following additional app settings for the BLE RX app: channel, sorting method, filter, logging option, and name option.
  2. Changed the app settings file names for BLE RX and TX apps to match standardized file naming convention (rx_ble.ini, tx_ble.ini).

@NotherNgineer NotherNgineer marked this pull request as ready for review December 4, 2023 06:39
@NotherNgineer NotherNgineer requested a review from iNetro December 4, 2023 06:40
iNetro
iNetro approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@iNetro iNetro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@iNetro iNetro merged commit ea02d98 into portapack-mayhem:next Dec 4, 2023
3 checks passed
@NotherNgineer NotherNgineer deleted the ble-app-settings branch December 4, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNetro iNetro iNetro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotherNgineer @iNetro