Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE spam ext app #1624

Merged
merged 12 commits into from
Dec 6, 2023
Merged

BLE spam ext app #1624

merged 12 commits into from
Dec 6, 2023

Conversation

htotoo
Copy link
Member

@htotoo htotoo commented Dec 4, 2023

Port of the BLE spam app (main functions only).

@htotoo htotoo marked this pull request as draft December 4, 2023 17:31
@eried
Copy link
Member

eried commented Dec 5, 2023

:P what would be the next step to complete this?

@htotoo
Copy link
Member Author

htotoo commented Dec 5, 2023 •
edited
Loading

Before these commit it used FW space instead of ext app space. Saved 2kb! A bit uglier solution, but that 2kb is much I think.
Also needs some work on the working logic to optimize it, but yet it works (popups slow a bit, but that could be another pr)

@htotoo htotoo marked this pull request as ready for review December 5, 2023 13:45
iNetro
iNetro approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@iNetro iNetro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I reviewed this before, but it was still in draft :P

@iNetro iNetro merged commit 1bf0d2b into portapack-mayhem:next Dec 6, 2023
3 checks passed
@htotoo htotoo deleted the blespam branch December 6, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNetro iNetro iNetro approved these changes

@gullradriel gullradriel Awaiting requested review from gullradriel

@Brumi-2021 Brumi-2021 Awaiting requested review from Brumi-2021

@NotherNgineer NotherNgineer Awaiting requested review from NotherNgineer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@htotoo @eried @iNetro