Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BLE RX filter to look at MAC address and device name only #1625

Closed

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Dec 6, 2023

I'm proposing to change BLE RX "filter" to look at MAC address and name strings only (versus the entire unprocessed packet), per enhancement suggestion #1623

If accepted, I will also update the BLE Wiki page accordingly.

@NotherNgineer NotherNgineer linked an issue Dec 6, 2023 that may be closed by this pull request
@NotherNgineer NotherNgineer requested a review from iNetro December 6, 2023 22:38
@NotherNgineer NotherNgineer marked this pull request as ready for review December 7, 2023 15:25
@iNetro
Copy link
Contributor

iNetro commented Dec 7, 2023

I'm proposing to change BLE RX "filter" to look at MAC address and name strings only (versus the entire unprocessed packet), per enhancement suggestion #1623

If accepted, I will also update the BLE Wiki page accordingly.

I'm not in favor of this. I like being able to search for specific data strings when needed, like filtering out for iBeacons and etc. If this is a hassle for some, I propose a setting of some sort to allow the option on what to filter for. I didn't get around to that and I think this would be the more appropriate solution.

@iNetro iNetro closed this Dec 7, 2023
@iNetro
Copy link
Contributor

iNetro commented Dec 7, 2023

See comment.

@NotherNgineer
Copy link
Contributor Author

Perhaps one way to accomplish this would be to add support for special keywords in the Filter string, such as "MAC:" to enable searching for digits in a MAC address. Anyways, I'll leave it up to you. Thanks for reviewing.

@NotherNgineer NotherNgineer deleted the blerx-filter branch December 21, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLE RX - add MAC address filtering option
2 participants