-
-
Notifications
You must be signed in to change notification settings - Fork 102
feat: add auto-hmr-plugin and autoHmr option #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
libondev
wants to merge
4
commits into
posva:main
Choose a base branch
from
libondev:refactor/hmr-dx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
aee9b7a
feat: add auto-hmr-plugin and autoHmr option
libondev 7abc277
chore: improve the handling of type errors.
libondev ea89aa8
Revert "chore: improve the handling of type errors."
libondev 9fdf339
refactor(auto-hmr): Judging whether to call handleHotUpdate based on ast
libondev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
import type { UnpluginOptions } from 'unplugin' | ||
import type { VariableDeclarator, ImportDeclaration } from 'estree' | ||
import type { AstNode } from 'rollup' | ||
|
||
function nameFromDeclaration(node?: VariableDeclarator) { | ||
return node?.id.type === 'Identifier' ? node.id.name : '' | ||
} | ||
|
||
function getRouterDeclaration(nodes?: VariableDeclarator[]) { | ||
return nodes?.find( | ||
(x) => | ||
x.init?.type === 'CallExpression' && | ||
x.init.callee.type === 'Identifier' && | ||
x.init.callee.name === 'createRouter' | ||
) | ||
} | ||
|
||
function getHandleHotUpdateDeclaration(node?: ImportDeclaration, modulePath?: string) { | ||
return ( | ||
node?.type === 'ImportDeclaration' && | ||
node.source.value === modulePath && | ||
node.specifiers.some( | ||
(x) => | ||
x.type === 'ImportSpecifier' && | ||
x.imported.type === 'Identifier' && | ||
x.imported.name === 'handleHotUpdate' | ||
) | ||
) | ||
} | ||
|
||
function hasHandleHotUpdateCall(ast: AstNode) { | ||
function traverse(node: any) { | ||
if (!node) return false; | ||
|
||
if ( | ||
node.type === 'CallExpression' && | ||
node.callee.type === 'Identifier' && | ||
node.callee.name === 'handleHotUpdate' | ||
) { | ||
return true; | ||
} | ||
|
||
// e.g.: autoRouter.handleHotUpdate() | ||
if ( | ||
node.type === 'CallExpression' && | ||
node.callee.type === 'MemberExpression' && | ||
node.callee.property.type === 'Identifier' && | ||
node.callee.property.name === 'handleHotUpdate' | ||
) { | ||
return true; | ||
} | ||
|
||
if (typeof node !== 'object') return false; | ||
|
||
for (const key in node) { | ||
if (key === 'type' || key === 'loc' || key === 'range') continue; | ||
|
||
const child = node[key]; | ||
if (Array.isArray(child)) { | ||
for (const item of child) { | ||
if (traverse(item)) return true; | ||
} | ||
} else if (typeof child === 'object' && child !== null) { | ||
if (traverse(child)) return true; | ||
} | ||
} | ||
|
||
return false; | ||
} | ||
|
||
return traverse(ast); | ||
} | ||
|
||
interface AutoHmrPluginOptions { | ||
modulePath: string | ||
} | ||
|
||
export function createAutoHmrPlugin({ modulePath }: AutoHmrPluginOptions): UnpluginOptions { | ||
return { | ||
name: 'unplugin-vue-router-auto-hmr', | ||
enforce: 'post', | ||
|
||
transform(code, id) { | ||
if (id.startsWith('\x00')) return | ||
|
||
// If you don't use automatically generated routes, | ||
// maybe it will be meaningless to deal with hmr? | ||
if (!code.includes('createRouter(') && !code.includes(modulePath)) { | ||
return | ||
} | ||
|
||
const ast = this.parse(code) | ||
|
||
let isImported = false | ||
let routerName: string | undefined | ||
let routerDeclaration: VariableDeclarator | undefined | ||
|
||
// @ts-expect-error | ||
for (const node of ast.body) { | ||
if ( | ||
node.type === 'ExportNamedDeclaration' || | ||
node.type === 'VariableDeclaration' | ||
) { | ||
if (!routerName) { | ||
routerDeclaration = getRouterDeclaration(node.type === 'VariableDeclaration' | ||
? node.declarations | ||
: node.declaration?.type === 'VariableDeclaration' | ||
? node.declaration?.declarations | ||
: undefined) | ||
|
||
routerName = nameFromDeclaration(routerDeclaration) | ||
} | ||
} else if (node.type === 'ImportDeclaration') { | ||
isImported ||= getHandleHotUpdateDeclaration(node, modulePath) | ||
} | ||
} | ||
|
||
if (routerName) { | ||
const isCalledHandleHotUpdate = hasHandleHotUpdateCall(ast) | ||
|
||
const handleHotUpdateCode = [code] | ||
|
||
// add import if not imported | ||
if (!isImported) { | ||
handleHotUpdateCode.unshift( | ||
`import { handleHotUpdate } from '${modulePath}'` | ||
) | ||
} | ||
|
||
// add handleHotUpdate call if not called | ||
if (!isCalledHandleHotUpdate) { | ||
handleHotUpdateCode.push(`handleHotUpdate(${routerName})`) | ||
} | ||
|
||
return { | ||
code: handleHotUpdateCode.join('\n') | ||
} | ||
} | ||
|
||
return | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.