Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions playground/typed-router.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ declare module 'vue-router/auto-routes' {
'/partial-[name]': RouteRecordInfo<'/partial-[name]', '/partial-:name', { name: ParamValue<true> }, { name: ParamValue<false> }>,
'/custom-path': RouteRecordInfo<'/custom-path', '/surprise-:id(\d+)', Record<never, never>, Record<never, never>>,
'/test-[a-id]': RouteRecordInfo<'/test-[a-id]', '/test-:a-id', { aId: ParamValue<true> }, { aId: ParamValue<false> }>,
'/test-broken-syntax': RouteRecordInfo<'/test-broken-syntax', '/test-broken-syntax', Record<never, never>, Record<never, never>>,
'/todos/': RouteRecordInfo<'/todos/', '/todos', Record<never, never>, Record<never, never>>,
'/todos/+layout': RouteRecordInfo<'/todos/+layout', '/todos/+layout', Record<never, never>, Record<never, never>>,
'/users/': RouteRecordInfo<'/users/', '/users', Record<never, never>, Record<never, never>>,
Expand Down Expand Up @@ -287,6 +288,10 @@ declare module 'vue-router/auto-routes' {
routes: '/test-[a-id]'
views: never
}
'src/pages/test-broken-syntax.vue': {
routes: '/test-broken-syntax'
views: never
}
'src/pages/todos/index.vue': {
routes: '/todos/'
views: never
Expand Down
69 changes: 61 additions & 8 deletions src/core/definePage.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { TransformResult } from 'vite'
import { expect, describe, it } from 'vitest'
import { definePageTransform, extractDefinePageNameAndPath } from './definePage'
import { mockWarn } from '../../tests/vitest-mock-warn'

const sampleCode = `
<script setup>
Expand All @@ -18,6 +19,7 @@ const b = 1
`

describe('definePage', () => {
mockWarn()
it('removes definePage', async () => {
const result = (await definePageTransform({
code: sampleCode,
Expand Down Expand Up @@ -153,7 +155,7 @@ definePage({
expect(result?.code).toMatchSnapshot()
})

it('throws if definePage uses a variable from the setup', async () => {
it('handles definePage using a variable from setup gracefully', async () => {
const code = `
<script setup>
const a = 1
Expand All @@ -162,13 +164,16 @@ definePage({
})
</script>
`
// the function syntax works with sync and async errors
await expect(async () => {
await definePageTransform({
code,
id: 'src/pages/basic.vue&definePage&vue',
})
}).rejects.toThrowError()
const result = await definePageTransform({
code,
id: 'src/pages/basic.vue&definePage&vue',
})

// Should return empty object instead of throwing
expect(result).toBe('export default {}')
expect(
'`definePage()` in <script setup> cannot reference locally declared variables'
).toHaveBeenWarned()
})

it('extracts name and path', async () => {
Expand Down Expand Up @@ -254,4 +259,52 @@ export default {
path: '/custom',
})
})

describe('error handling', () => {
const codeWithSyntaxError = `
<script setup>
definePage({
name: 'test',, // syntax error: extra comma
path: '/test'
})
</script>

<template>
<div>hello</div>
</template>
`

it('handles syntax errors gracefully when extracting definePage', async () => {
const result = await definePageTransform({
code: codeWithSyntaxError,
id: 'src/pages/broken.vue?definePage&vue',
})

// Should return empty object instead of crashing
expect(result).toBe('export default {}')
expect('Failed to process definePage:').toHaveBeenWarned()
})

it('handles syntax errors gracefully when removing definePage from source', async () => {
const result = await definePageTransform({
code: codeWithSyntaxError,
id: 'src/pages/broken.vue',
})

// Should return undefined (no transform) instead of crashing
expect(result).toBeUndefined()
expect('Failed to process definePage:').toHaveBeenWarned()
})

it('handles extractDefinePageNameAndPath with syntax errors gracefully', async () => {
const result = await extractDefinePageNameAndPath(
codeWithSyntaxError,
'src/pages/broken.vue'
)

// Should return null/undefined instead of crashing
expect(result).toBeUndefined()
expect('Failed to extract definePage info:').toHaveBeenWarned()
})
})
})
Loading