Add a parse command #198
Add a parse command #198
Conversation
| Parse { | ||
| /// What to parse the input as | ||
| #[arg(long, value_enum)] | ||
| parse_as: ParseAs, |
There was a problem hiding this comment.
I'd suggest renaming this into as because
anthem parse --as program file.lp
feels much more natural than
anthem parse --parse-as program file.lp
There was a problem hiding this comment.
@ZachJHansen Btw, is the word as proper English grammar here or is anthem parse --into ... better?
There was a problem hiding this comment.
Either is fine - I prefer "as"
| @@ -22,6 +22,20 @@ pub enum Command { | |||
| input: Option<PathBuf>, | |||
| }, | |||
|
|
|||
| /// Parse and output an input | |||
| pub enum Output { | ||
| #[default] | ||
| Debug, | ||
| Default, |
There was a problem hiding this comment.
I find it rather weird to have a Debug that is the default and a Default that is not. Given the fact that these names originate form the names of our formatters, I suggest not to rename things here. I'd also suggest not to change the default as the Debug output is much more helpful than the Default output.
That said, I my improvement ideas are limited -- and I would give this a pass if we are unable to find something better.
This PR fixes #176
The parse command has two arguments:
parse-asto choose what the input is parse as (i.e. program, theory, specification or user guide)outputeither debug output or the default output