Skip to content

Some additional code cleanup #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025

Conversation

mpnow
Copy link
Contributor

@mpnow mpnow commented Jul 8, 2025

Additional code cleanup

NodeConnector.cs

  • Cleaned up usings.

PowerSyncData.cs

  • SaveItemAsync()
    • Null out completed_by if item is marked as incomplete.
    • Write completed_by on INSERT for consistency's sake.
    • Fields rearrranged on INSERT for more logical ordering.

TodoItem.cs

  • Formatting cleanup.

ListsPage.xaml.cs and TodoListPage.xaml.cs

  • Refactored OnDeleteClicked() to avoid possible null reference.
  • Changed variable declarations to all use implicit typing for consistency's sake.

@mpnow
Copy link
Contributor Author

mpnow commented Jul 8, 2025

Thanks for merging my last PR!

This one doesn't have any bug fixes in it per se, so it's of course up to you whether you want to merge it in or not (or cherry pick some of the changes that you want in).

@Chriztiaan
Copy link
Collaborator

Chriztiaan commented Jul 8, 2025

Thanks for merging my last PR!

This one doesn't have any bug fixes in it per se, so it's of course up to you whether you want to merge it in or not (or cherry pick some of the changes that you want in).

Cleanup and fixes are appreciated and encouraged! Thanks for spending the time to help!
I'll give it a test.

Copy link
Contributor Author

@mpnow mpnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chriztiaan Works for me!

@Chriztiaan Chriztiaan merged commit 2728eab into powersync-ja:main Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants