Merge pull request #234 from stanriders/fix-osu-taiko-objinspection

Fix osu, taiko object inspection not drawing correctly, fix missing osu diff values
ppy · Dec 6, 2024 · a5be3a7 · a5be3a7
2 parents 976d07b + 1a1d989
commit a5be3a7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/PerformanceCalculatorGUI/Screens/ObjectInspection/ObjectDifficultyValuesContainer.cs b/PerformanceCalculatorGUI/Screens/ObjectInspection/ObjectDifficultyValuesContainer.cs
@@ -133,6 +133,10 @@ private void drawOsuValues(OsuDifficultyHitObject hitObject)
             if (hitObject.Angle is not null)
                 flowContainer.Add(new ObjectInspectorDifficultyValue("Angle", double.RadiansToDegrees(hitObject.Angle.Value)));
 
+            flowContainer.Add(new ObjectInspectorDifficultyValue("Lazy Jump Dist", hitObject.LazyJumpDistance));
+            flowContainer.Add(new ObjectInspectorDifficultyValue("Min Jump Dist", hitObject.MinimumJumpDistance));
+            flowContainer.Add(new ObjectInspectorDifficultyValue("Min Jump Time", hitObject.MinimumJumpTime));
+
             if (hitObject.BaseObject is Slider)
             {
                 flowContainer.AddRange(new Drawable[]
@@ -146,8 +150,6 @@ private void drawOsuValues(OsuDifficultyHitObject hitObject)
                     },
                     new ObjectInspectorDifficultyValue("Travel Time", hitObject.TravelTime),
                     new ObjectInspectorDifficultyValue("Travel Distance", hitObject.TravelDistance),
-                    new ObjectInspectorDifficultyValue("Min Jump Dist", hitObject.MinimumJumpDistance),
-                    new ObjectInspectorDifficultyValue("Min Jump Time", hitObject.MinimumJumpTime)
                 });
             }
         }

diff --git a/PerformanceCalculatorGUI/Screens/ObjectInspection/OsuObjectInspectorRuleset.cs b/PerformanceCalculatorGUI/Screens/ObjectInspection/OsuObjectInspectorRuleset.cs
@@ -94,7 +94,7 @@ private void updateState(DrawableHitObject hitObject, ArmedState state)
 
                                 hitObject.Delay(hitObjectDuration)
                                          .FadeTo(0.25f, 200f, Easing.Out)
-                                         .Delay(nextHitObject.StartTime - hitObject.StartTimeBindable.Value - hitObjectDuration)
+                                         .Delay(nextHitObject.StartTimeBindable.Value - hitObject.StartTimeBindable.Value - hitObjectDuration)
                                          .FadeOut(100f, Easing.Out)
                                          .Expire();
                             }

diff --git a/PerformanceCalculatorGUI/Screens/ObjectInspection/TaikoObjectInspectorRuleset.cs b/PerformanceCalculatorGUI/Screens/ObjectInspection/TaikoObjectInspectorRuleset.cs
@@ -26,6 +26,8 @@ public TaikoObjectInspectorRuleset(Ruleset ruleset, IBeatmap beatmap, IReadOnlyL
         {
             difficultyHitObjects = difficultyCalculator.GetDifficultyHitObjects(beatmap, clockRate)
                                                        .Cast<TaikoDifficultyHitObject>().ToArray();
+
+            ShowSpeedChanges.Value = true;
         }
 
         public override bool PropagatePositionalInputSubTree => false;