Skip to content

Adjust multiplayer json #12192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2025
Merged

Adjust multiplayer json #12192

merged 4 commits into from
Jun 2, 2025

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented May 27, 2025 •
edited by notbakaneko
Loading

  • move beatmaps and beatmapsets to their own arrays to handle freestyle
  • move details for game started event to playlist item as otherwise it'll be pretty difficult to deal with

depends on

@nanaya nanaya mentioned this pull request May 27, 2025
Open
1 task
@nanaya nanaya force-pushed the multiplayer-json-shape branch 2 times, most recently from 492ef46 to a7bec27 Compare May 29, 2025 05:28
@notbakaneko
Copy link
Collaborator

Does the response structure change have any effect on your end @bdach ?

@nanaya
Copy link
Collaborator Author

nanaya commented May 29, 2025

I don't think this involves client at the moment and I'm handling the web side.

@bdach
Copy link
Contributor

bdach commented May 29, 2025

Basically nobody other than web itself should be using the events endpoint, yeah.

@notbakaneko notbakaneko enabled auto-merge June 2, 2025 05:14
@notbakaneko notbakaneko merged commit 8995f9b into ppy:master Jun 2, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanaya @notbakaneko @bdach