Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Main Page subsections #2728

Open
cl8n opened this issue Oct 27, 2019 · 11 comments
Open

Style Main Page subsections #2728

cl8n opened this issue Oct 27, 2019 · 11 comments

Comments

@cl8n
Copy link
Member

cl8n commented Oct 27, 2019

idk why we kept these group/subsection things in parenthesis, they look terrible and get split across lines

@cl8n cl8n added the website label Oct 27, 2019
@cl8n cl8n added this to the Candidate Issues milestone Oct 27, 2019
@ghost
Copy link

ghost commented Oct 27, 2019

#2731 Feel free to edit anything here.

@ghost ghost mentioned this issue Oct 27, 2019
@sr229
Copy link
Contributor

sr229 commented Oct 28, 2019

I'm more in favor of #2730 than #2731.

@cl8n cl8n removed this from the Candidate Issues milestone Nov 15, 2020
@TicClick
Copy link
Contributor

I guess this is not resolved yet, and the main page blocks need further improvements, although they definitely look better without braces (context)

@TicClick
Copy link
Contributor

TicClick commented May 21, 2021

the main page update for #2606 is in progress, marking this as blocked

@TicClick TicClick added the state/blocked don't merge label May 21, 2021
@cl8n
Copy link
Member Author

cl8n commented May 22, 2021

been a long time but I think I was trying to say inline styling for these sections isn't the way to go. parenthesis or not, the sub-section-titles have no significance compared to the articles within, and titles wrap unnecessarily, and extra separator dots appear at end of line sometimes, ...

as far as wiki is concerned these should probably just be lists contained in a styling block, and web can take care of how it looks. I was looking into rewriting the main page renderer anyway cuz the setup is really odd web-side. syntax would be something like this for each panel. headers and lists would have custom styling under Panel instead of the classes applied via HTML currently

?

{{{ Panel

## People

*some description from #5506*

{{{ Panel Section

### [The Team](/wiki/People/The_Team)

- [Developers](/wiki/People/The_Team/Developers)
- [Global Moderation Team](/wiki/People/The_Team/Global_Moderation_Team)
- ...

}}}

...

}}}

also I'm not really following how this is blocked by your other updates

@TicClick
Copy link
Contributor

thought it was wiki only and the changes would be more drastic, which is tough to do at the same time as updating the page

@TicClick TicClick removed the state/blocked don't merge label Aug 19, 2021
@TicClick
Copy link
Contributor

rewrite done. reposting important stuff from the pull:

also, infobox example: #5440

@Walavouchey
Copy link
Member

is this still tracking anything?

@TicClick
Copy link
Contributor

yes, it still looks poor and the subsections are not styled at all (this needs someone to experiment with the design and find something similar to #5506 (comment) which didn't happen)

@Walavouchey
Copy link
Member

the preview in the comment you linked looks exactly like how the main page looks now, so i'm not sure on what you mean there. but i agree that the uh... design of the main page is quite dull

@RockRoller01
Copy link
Contributor

Two things that personally bother me:

  • some, but only some, group headers also function as a link to their index page. This should be either none or all imo
  • sometimes different groups of articles are seperated by a gap between the groups, while others will have a label (and sometimes both types are mixed)
    first
    image
    second
    image

Both of these things contribute to the visual mess and non uniformity, with varying length group introductions not helping. Like developers is barely over one line, while others like mapping feature a full paragraph

@cl8n cl8n removed the area:website label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants