Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini-Rewrite of Main Page #2731

Closed
wants to merge 4 commits into from
Closed

Mini-Rewrite of Main Page #2731

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2019

Tries to resolve #2728

The current Main Page is outdated.

@ghost ghost mentioned this pull request Oct 27, 2019
@ghost ghost mentioned this pull request Oct 27, 2019
Copy link
Contributor

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sr229
Copy link
Contributor

sr229 commented Oct 27, 2019

Please make your commits descriptive, it defeats the point of having a VCS to know which got changed.

@@ -3,35 +3,35 @@ layout: "main_page"
---

<div class="wiki-main-page__blurb">
Welcome to osu!, a free rhythm game created by peppy with its primary focus of clicking circles along with the beat. Aside from the main game mode, which is referred to many as *osu!standard*, osu! has three other different game modes, namely: osu!taiko, osu!catch, and osu!mania.
Welcome to to the osu! knowledge base, or otherwise known as the osu!wiki. This is a resource for new and veteran players to use for osu!.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you really shouldn't be writing prose. read this back to yourself. you're writing words for the sake of writing words, not to actually convey anything of value (focus on the second line)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading back, yeah I think this was completely butchering the entire blurb and its not even delivering the message propery. Please rewrite this.

@Joehuu
Copy link
Member

Joehuu commented Oct 28, 2019

Closing in favor of #2730.

@Joehuu Joehuu closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style Main Page subsections
4 participants