-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up format of Skinning/Sounds
and add Nightcore sample info
#10863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- why are only some of these in tables? the ones which have additional information could have a "Notes" column for instance
- expand contractions ("aren't" --> "are not", etc.)
- "osu! client", "osu! cookie" instead of "osu!client" and "osu!cookie"
- the article should probably be renamed to something more grammatically correct than "Sounds skinning"
will check in more detail later
Some of sounds are similar in filename and usage, then I tried to merge them into one line, for example the hitsound sets and the
Just kept them without changes when rewriting, will change later.
|
I have very far down a todo list that I wanted to write about these files:
idk if I'll ever get to it but maybe it's relevant to do in this PR. |
Have read osu! lazer source code and tried on stable by myself. It's really odd that I didn't find And found the sound playing mechanic of */3 or */6 times, can add it to this article (or |
in stable
otherwise it works same as lazer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest of the changes seem fine, there's still a lot to improve about this article but the new layout here is certainly better
just fix NC and that's good for this PR
just looks better.
Skinning/Sounds
Skinning/Sounds
and add Nightcore sample info
This might be part of the solution of #2589
Self-check