Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Beatmap editor index #3129

Merged
merged 10 commits into from
Apr 23, 2020
Merged

Rewrite Beatmap editor index #3129

merged 10 commits into from
Apr 23, 2020

Conversation

Pennek
Copy link
Contributor

@Pennek Pennek commented Jan 31, 2020

Closes part of #3128

Needs further reorganizing once more tasks in #3128 are completed.

@Pennek Pennek requested a review from cl8n January 31, 2020 17:13
@Pennek Pennek mentioned this pull request Jan 31, 2020
12 tasks
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the sections except Design start with prose that's not really needed:

  • compose: "where a majority of beatmapping happens"
  • timing: "where all new beatmaps begin"
  • song setup: "the first place all new beatmaps have to go through"

the first sentence of each should at least start to introduce what these things actually do

@cl8n cl8n added the rewrite label Jan 31, 2020
@Pennek Pennek requested a review from cl8n February 2, 2020 12:48
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely needs to be revisited after some of the sub articles are worked out-- this article is kinda forced to be awkward when you have to talk about what is directly below it

@cl8n cl8n merged commit db1c2d6 into ppy:master Apr 23, 2020
@Pennek Pennek deleted the Beatmap-Editor-Index branch July 4, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants