-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple display modes (including circle gameplay) to latency certification #18635
Conversation
…rt for circle gameplay
Unsure whether to leave UR showing or not, pending @smoogipoo feedback I guess. I'd prefer to remove it for the initial release to keep things simple, but don't mind too much either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On extreme settings, the circle could conflict with the "here" linked label:
Also settings appear on results screen as well, conflicting with the continue button:
Probably should hide there instead.
Requesting change for the latency mode cycling logic, as that causes a crash when a user presses Space twice. Other suggestions are minor.
Co-authored-by: Salman Ahmed <[email protected]>
Co-authored-by: Salman Ahmed <[email protected]>
I personally think it's fine showing UR, don't see it as a factor that makes the test easier/harder. All looking good to me. |
Tending to remove the UR meter, but only because it doesn't seem to be adding much value to my rudimentary tests, due to not having something to keep timing with (i.e. audio). Can go in as-is as it wouldn't be a detriment to the test as far as I can tell. |
I think I'll remove initially. I'll mention in the FAQ and we can add back if there's demand. |
Scrolling mode will follow but be very similar in implementation if there's no issues with this one.