Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple display modes (including circle gameplay) to latency certification #18635

Merged
merged 27 commits into from
Jun 11, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Jun 10, 2022

Scrolling mode will follow but be very similar in implementation if there's no issues with this one.

@peppy
Copy link
Member Author

peppy commented Jun 10, 2022

Unsure whether to leave UR showing or not, pending @smoogipoo feedback I guess.

I'd prefer to remove it for the initial release to keep things simple, but don't mind too much either way.

Copy link
Member

@frenzibyte frenzibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On extreme settings, the circle could conflict with the "here" linked label:
CleanShot 2022-06-11 at 14 28 23@2x

Also settings appear on results screen as well, conflicting with the continue button:
CleanShot 2022-06-11 at 14 30 29@2x

Probably should hide there instead.


Requesting change for the latency mode cycling logic, as that causes a crash when a user presses Space twice. Other suggestions are minor.

@peppy
Copy link
Member Author

peppy commented Jun 11, 2022

On extreme settings, the circle could conflict with the "here" linked label: CleanShot 2022-06-11 at 14 28 23@2x

probably fine for now.

other issues should be fixed.

@frenzibyte
Copy link
Member

I personally think it's fine showing UR, don't see it as a factor that makes the test easier/harder. All looking good to me.

frenzibyte
frenzibyte previously approved these changes Jun 11, 2022
@smoogipoo
Copy link
Contributor

smoogipoo commented Jun 11, 2022

Tending to remove the UR meter, but only because it doesn't seem to be adding much value to my rudimentary tests, due to not having something to keep timing with (i.e. audio). Can go in as-is as it wouldn't be a detriment to the test as far as I can tell.

@peppy
Copy link
Member Author

peppy commented Jun 11, 2022

I think I'll remove initially. I'll mention in the FAQ and we can add back if there's demand.

@smoogipoo smoogipoo merged commit 12ff980 into ppy:master Jun 11, 2022
@peppy peppy deleted the latency-comparer-more-modes branch June 13, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants