Fix Strict Tracking mod sliderend combo issue

[Cwazywierdo]

Closes #19232

[bdach]

In theory this looks better now, but there's a display issue. If slider tails are to be judged as SliderTick, then this becomes a problem:

osu/osu.Game.Rulesets.Osu/OsuRuleset.cs

Lines 256 to 274 in 27ec8f3

	public override string GetDisplayNameForHitResult(HitResult result)
	{
	switch (result)
	{
	case HitResult.LargeTickHit:
	return "slider tick";
	case HitResult.SmallTickHit:
	return "slider end";
	case HitResult.SmallBonus:
	return "spinner spin";
	case HitResult.LargeBonus:
	return "spinner bonus";
	}
	return base.GetDisplayNameForHitResult(result);
	}

The fact that the judgement names are overridden makes this confusing because it will seem like tails have been "replaced by ticks". Related: #18764 (comment)

[frenzibyte]

The only simplest way I can think of is allowing Mods to provide a map between the original HitResult and the modified version, and using that in GetStatisticsForDisplay. That sounds super dodge though, and feels like HitResult isn't a good enum to use for mapping to judgement names (perhaps a Judgement.Name property would be better, along with a list of valid Judgements provided at Ruleset or otherwise).

[bdach]

The only simplest way I can think of is allowing Mods to provide a map between the original HitResult and the modified version, and using that in GetStatisticsForDisplay.

No, the simplest thing to do here - code-wise - would be to remove GetDisplayNameForHitResult() entirely. Which is the one I'd probably vote for, on technical grounds alone. There are already two known cases of this method not really going well together with intentions in that respect. Unfortunately this would be done at the expense of user understanding.

[frenzibyte]

Yeah actually, upon taking a second look this doesn't seem feasible to fix without making each mod specify which HitResults they changed, and that doesn't look pleasant to have (unless we fire up a ScoreProcessor for every score and map judgement results to the hit results in the statistics). But on the other hand, I'm quite unsure about displaying "large tick" and "small tick" to the user, and have them mentally map that to the slider tick/end.