Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of "Radiate" Setting for transform #19480

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

mk56-spn
Copy link
Contributor

@mk56-spn mk56-spn commented Jul 30, 2022

As discussed here:

#19446

adds another "mode" called "Emit" for the Transform Mod, as well as adjusting the tooltip and a few other small parameters

@bdach
Copy link
Collaborator

bdach commented Jul 31, 2022

Dunno if I conceptually agree with this being a setting? It makes transform into an indescribable mod, as evidenced by the description (basically "stuff moves").

@mk56-spn
Copy link
Contributor Author

Dunno if I conceptually agree with this being a setting? It makes transform into an indescribable mod, as evidenced by the description (basically "stuff moves").

i made it a subsetting as per the suggestion and tacit agreement of a commenter and ppy

at first i felt like you on the topic but i feel the compromise is worth it since it allows the grouping of any future "approach movement" type mods to be grouped as a setting, instead of having it be a cluster---- of fun mods ( which is another thing, ive played 5 hours of transform as of recent and it absolutely has no place in fun, its clearly difficulty increasing but i digress)

@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 31, 2022
@mk56-spn mk56-spn changed the title Implementation of "Emit" Setting for traceable Implementation of "Radiate" Setting for traceable Aug 14, 2022
@enoslayd
Copy link

Isnt this pr for transfom mod not traceable?

@mk56-spn mk56-spn changed the title Implementation of "Radiate" Setting for traceable Implementation of "Radiate" Setting for transform Aug 18, 2022
@mk56-spn
Copy link
Contributor Author

Isnt this pr for transfom mod not traceable?

yep, fixed

@peppy peppy removed the proposal label Sep 9, 2022
@mk56-spn
Copy link
Contributor Author

Not for review

fixed merge conflicts and undid the change to the transform times for the default settings, will be adding a test scene

@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 18, 2022
@mk56-spn
Copy link
Contributor Author

mk56-spn commented Oct 13, 2022

in the interest of getting this out of limbo id be ok with removing this change #19480 (comment), sound good? not neccesarily wanting to hurry this along ive just realised with more playing that its less necessary than i thought

@peppy
Copy link
Member

peppy commented Oct 13, 2022

It may help.

@mk56-spn mk56-spn requested a review from peppy December 23, 2022 12:03
@peppy peppy marked this pull request as draft June 16, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants