Mods: Add New "Wayback" Mod #21673

jessiejs · 2022-12-16T21:52:15Z

Wayback delays your cursor by a variable amount of time.
This mod provides an interesting challenge.
In order to implement this, I had to introduce an interface for modifying the cursor position.

The Wayback mod delays the motion of your cursor by a little bit. It makes the cursor feel sorta slippery. This does not delay the actual internal cursor, only the visuals. Warning: This is ducktaped together with spaghetti code.

mk56-spn

I don't think this will be accepted by the core devs but here's a few things i've personally spotted that cant remain the way they are

mk56-spn · 2022-12-16T21:57:08Z

osu.Game/Rulesets/Mods/ModWayback.cs

+                }
+                return multiplier;
+            }
+        }


multipliers should not be added initially

mk56-spn · 2022-12-16T22:02:06Z

osu.Game/Rulesets/UI/GameplayCursorContainer.cs

+            {
+                TruePosition = TargetPosition;
+            }
+            ActiveCursor.Position = TruePosition;


changes from mods should be done through interfaces ( check any other mod to see how its done )

mk56-spn · 2022-12-16T22:02:12Z

osu.Game.Rulesets.Osu/UI/Cursor/OsuCursorContainer.cs

@@ -31,7 +31,7 @@ public partial class OsuCursorContainer : GameplayCursorContainer, IKeyBindingHa

        private readonly Bindable<bool> showTrail = new Bindable<bool>(true);

-        private readonly Drawable cursorTrail;
+        public readonly Drawable CursorTrail;


i dont think this will fly, theres no way mods should be accesing the cursor directly, check other mods, i dont think theres a single one that access whatever its changing in this fashion

mk56-spn · 2022-12-16T22:02:16Z

osu.Game.Rulesets.Osu/Mods/OsuModWayback.cs

+            osuPlayfield.Cursor.Delayed = true;
+			osuPlayfield.Cursor.FollowSpeed = FollowSpeed.Value;
+            ((OsuCursorContainer)osuPlayfield.Cursor).CursorTrail.Alpha = 0;
+            osuPlayfield.Smoke.Alpha = 0;


Why are you setting values that don't change during gameplay in update?? this runs continously

ghost · 2022-12-17T00:26:02Z

Wait why are we disabling the cursor trail/smoke? I don't see any reason to do this (apart from the difficulty of implementation)

also we prefer to merge from topic branches instead of from master, see CONTRIBUTING.md

ghost · 2022-12-17T00:32:05Z

osu.Game/Rulesets/UI/GameplayCursorContainer.cs

+            if (Delayed)
+            {
+                TruePosition = Vector2.Lerp(TruePosition, TargetPosition, (float)Time.Elapsed / 1000 * FollowSpeed);
+            }
+            else
+            {
+                TruePosition = TargetPosition;
+            }
+            ActiveCursor.Position = TruePosition;


What is the point of TruePosition here? Can't you just set ActiveCursor.Position directly?

ghost · 2022-12-17T00:32:10Z

osu.Game/Rulesets/Mods/ModWayback.cs

+                return multiplier;
+            }
+        }
+        public override Type[] IncompatibleMods => new Type[] { typeof(ModNoScope) };


Might want to add autopilot to the list of incompatible mods

It is, in the osu ruleset, because there is no generic ModAutopilot, just OsuModAutopilot, but thanks for the feedback!

ghost · 2022-12-17T00:32:42Z

osu.Game/Rulesets/Mods/ModWayback.cs

+                double multiplier = 1;
+                float followSpeed = FollowSpeed.Value;
+                double pos = 0;
+                while (pos < 90)
+                {
+                    multiplier += 0.01;
+                    pos += (100 - pos) / 100 * followSpeed;
+                }
+                return multiplier;


What is this supposed to do? I don't understand this

You probably shouldn't put that much thought into score multipliers for the time being.

ghost · 2022-12-17T00:32:46Z

osu.Game.Rulesets.Osu/UI/Cursor/OsuCursorContainer.cs

@@ -170,7 +170,7 @@ private partial class DefaultCursorTrail : CursorTrail
            [BackgroundDependencyLoader]
            private void load(TextureStore textures)
            {
-                Texture = textures.Get(@"Cursor/cursortrail");
+                Texture = textures.Get(@"Cursor/CursorTrail");


i have a feeling this will break something...

jessiejs · 2022-12-18T16:59:00Z

Thank you for pointing out these flaws in my code.
I should be able to start fixing these issues on Monday.

jessiejs · 2022-12-19T18:22:49Z

I think I've made all the changes requested.
Please tell me if it needs any more changes.

mk56-spn · 2022-12-23T14:28:53Z

still needs a lot of work, outside of code issues which i might be willing to fix myself, i have issues with how the mod works right now in general, because the cursor isnt delayed, its simply "magnetised", id expect it to follow the exact path the real cursor took but with some delay

jessiejs · 2022-12-24T02:44:40Z

I made the changes requested.
Personally, I think we should rename the mod to "Ping" now, for clarity.

BlauFx · 2023-01-04T22:08:14Z

osu.Game.Rulesets.Osu/UI/Cursor/OsuCursorContainer.cs

+		protected override void Update() {
+			foreach (IHidesCursorTrail modifier in Mods.OfType<IHidesCursorTrail>())
+            {
+                cursorTrail.Alpha = 0;
+            } // FIXME: Don't do this every frame. It's only like this right now because for some reason it won't work if I only do it once. 
+			base.Update();
+		}
+


If you want to get the PR into a mergeable state this definitely needs to be fixed

BlauFx · 2023-01-04T22:16:57Z

osu.Game/Rulesets/UI/GameplayCursorContainer.cs

+            Position = TargetPosition;
+            foreach (IModifiesCursorMovement modifier in Mods.OfType<IModifiesCursorMovement>())
+            {
+                Position = modifier.UpdatePosition(TargetPosition, (float)Time.Elapsed / 1000f);
+            }


Something like this should be done in another class, see: this or this

Am I being dumb, because it looks like the examples given don't have it done in another class.

My point is just that I don't think a cursor should check if there are any mods and apply them if necessary. Imo this task shouldn't do a cursor.

I'm not exactly sure what you meant, I moved it to Playfield. Is this correct?

peppy · 2023-01-09T07:16:32Z

I'm not sure what it should be named, but definitely not "wayback".

mk56-spn · 2023-01-09T20:51:14Z

"set back" perhaps?

Mods: Add New "Wayback" Mod

b87565b

The Wayback mod delays the motion of your cursor by a little bit. It makes the cursor feel sorta slippery. This does not delay the actual internal cursor, only the visuals. Warning: This is ducktaped together with spaghetti code.

pull-request-size bot added the size/L label Dec 16, 2022

mk56-spn reviewed Dec 16, 2022

View reviewed changes

ghost reviewed Dec 17, 2022

View reviewed changes

jessiejs added 2 commits December 19, 2022 10:01

Merge branch 'ppy:master' into master

9e0c427

Wayback: Tons Of Changes

8584d5d

jessiejs added 2 commits December 21, 2022 08:16

Fix Formatting Issue in CatchCursorContainer

c086ea3

Merge branch 'master' into master

789f226

jessiejs requested a review from mk56-spn December 22, 2022 00:00

Modify The Way Wayback Works

a9a3b39

BlauFx reviewed Jan 4, 2023

View reviewed changes

jessiejs added 2 commits January 6, 2023 11:41

Optimize IHidesCursorTrail

2132aa7

Merge branch 'ppy:master' into master

120f4a4

jessiejs added 3 commits January 10, 2023 13:59

Move Cursor Position Calculation To Playfield

6d329cd

Merge branch 'master' of https://github.com/codelikecraze/osu

07b0cf9

Change Default Delay

7b4a54b

jessiejs requested review from a user and mk56-spn and removed request for mk56-spn and a user January 23, 2023 04:51

jessiejs removed the request for review from a user February 19, 2023 23:25

jessiejs requested a review from mk56-spn February 19, 2023 23:25

peppy marked this pull request as draft June 16, 2023 06:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mods: Add New "Wayback" Mod #21673

Mods: Add New "Wayback" Mod #21673

jessiejs commented Dec 16, 2022 •

edited

Loading

mk56-spn left a comment

mk56-spn Dec 16, 2022

mk56-spn Dec 16, 2022

mk56-spn Dec 16, 2022

mk56-spn Dec 16, 2022

ghost commented Dec 17, 2022 •

edited by ghost

Loading

ghost Dec 17, 2022

ghost Dec 17, 2022

jessiejs Dec 19, 2022

ghost Dec 17, 2022

ghost Dec 17, 2022

jessiejs commented Dec 18, 2022

jessiejs commented Dec 19, 2022

mk56-spn commented Dec 23, 2022 •

edited

Loading

jessiejs commented Dec 24, 2022

BlauFx Jan 4, 2023

jessiejs Jan 6, 2023

jessiejs Jan 6, 2023

BlauFx Jan 4, 2023

jessiejs Jan 6, 2023

BlauFx Jan 7, 2023

jessiejs Jan 10, 2023

peppy commented Jan 9, 2023

mk56-spn commented Jan 9, 2023

Mods: Add New "Wayback" Mod #21673

Are you sure you want to change the base?

Mods: Add New "Wayback" Mod #21673

Conversation

jessiejs commented Dec 16, 2022 • edited Loading

mk56-spn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Dec 17, 2022 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessiejs commented Dec 18, 2022

jessiejs commented Dec 19, 2022

mk56-spn commented Dec 23, 2022 • edited Loading

jessiejs commented Dec 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peppy commented Jan 9, 2023

mk56-spn commented Jan 9, 2023

jessiejs commented Dec 16, 2022 •

edited

Loading

ghost commented Dec 17, 2022 •

edited by ghost

Loading

mk56-spn commented Dec 23, 2022 •

edited

Loading