Add "No sliding" mod for osu! #22067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still disagree with there being settings to slow down and limit BPM. It should be handled entirely behind the scenes ( aka forced on when appropriate ) . Players should not have access to this sort of thing imo. It just looks messy. Some tests to cover the special conversion cases would be nice to see as well Other than that LGTM |
|
@Feodor0090 i'd agree with applying the feedback above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #20044 - there were conflicts which I couldn't handle so decided to reopen this on top of actual branch.
Also fixed an oversight which made kicksliders ignore slowing setting and moved conversion code pieces to better places.