Calculate hit windows in performance calculator instead of databased difficulty attributes

[tsunyoku]

See #31595 (comment).

Depends on ppy/osu-queue-score-statistics#321 so that score.BeatmapInfo.Difficulty can be used in the calculator server-side.

[tsunyoku]

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#31735
SCORE_PROCESSOR_B=ppy/osu-queue-score-statistics#321

[smoogipoo]

Can the great/ok attribute definitions be removed too?

[stanriders]

You should do the same for other rulesets too then

[tsunyoku]

Yes we can, but it's worth noting these other usages are not new. Note the following:

• osu!mania's GreatHitWindow difficulty attribute can be removed with no consideration. It isn't even used in the first place, so useless storage.
• osu!taiko's GreatHitWindow and OkHitWindow difficulty attributes can be removed in the same way this PR already does for osu!, and replace it with calculations in the performance calculator.

Following from https://discord.com/channels/188630481301012481/380598781432823815/1334524621625491507, I need to push a fix for the osu! changes to ensure that any mods which affect the base overall difficulty are applied to the beatmap difficulty. However, I'm unsure if this is going to result in a double application of mods in the case the beatmap provided already had them applied... I'm thinking if this is coming from the PP counter, or osu-tools, it's going to use a beatmap which already has the beatmap difficulty modified in context of the score. Maybe this could be done on the server-side so we can trust the beatmap difficulty object in the performance calculator and it will work in either case.

In doing this, I noticed that we may be able to go an extra step and remove the OverallDifficulty attribute from osu!'s difficulty attributes entirely.

[github-actions]

Target: #31735
Spreadsheet: https://docs.google.com/spreadsheets/d/18el6GB0pH5Yr0y08lkqqkOJ0WevvAI0ZczFdVP2e94s/edit

[smoogipoo]

I guess it depends on what your goals are here. If the goal is only to remove the newly added attribute, then sure, but I was intending to go the full way and remove every single one to reduce DB storage requirements. Good catch on OD, perhaps the AR attribute too?