Add support for optgroup #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for optgroup tags when rendering the plugin from a select tag (there's also a bug fix on line 105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that I've updated adds support for the optgroup tag when rendering the plugin from an inline select tag. I added two new classes (one for the optgroup row and one for sub-options of an optgroup tag) and some basic styling, but you might want to use a different style as a default in your plugin. data-imagesrc and data-description both work for all three types of elements.
I did not minify the code because I don't know what service/settings you use for your plugin so I figured I'd let you handle that.
There's also one typo/bug I fixed. It's on line 105 in my code (101 in yours), a missing > stops the code from working.