Skip to content

Add Pre-commit hooks#87

Merged
Kayle-Verhiel merged 2 commits intomainfrom
feature/pre-commit-hooks
Mar 19, 2026
Merged

Add Pre-commit hooks#87
Kayle-Verhiel merged 2 commits intomainfrom
feature/pre-commit-hooks

Conversation

@GiorgosNik
Copy link
Copy Markdown
Collaborator

@GiorgosNik GiorgosNik commented Mar 19, 2026

Issue

ISSUE > Add Pre-commit hooks

Description

Added a number of pre-commit hooks:

  • trailing-whitespace
  • end-of-file-fixer
  • mixed-line-ending --fix=lf :Normalizes mixed line endings to LF
  • check-merge-conflict :Fails if there are conflict markers
  • check-json: JSON validator
  • check-yaml: same for yaml
  • check-added-large-files --maxkb=1500
  • detect-private-key
  • detect-aws-credentials
  • ruff --fix : Execute ruff linting for Python files and auto-fix
  • ruff-format: Ruff formatter
  • nbstripout: Strip notebook metadata
  • terraform-fmt
  • frontend-eslint

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation update
  • Configuration / infrastructure change
  • Other:

How has this been tested?

  • Unit tests
  • Manual testing
  • No testing required

Notes for reviewers

This commit refactored everything by removing special characters, end of file etc.
Do not be scared by big size of the changes.

Checklist

  • I filled in the releated issue link
  • My PR has the name of the branch
  • My code follows the project's coding style
  • I have reviewed my own changes before requesting review
  • I have added or updated relevant documentation
  • My changes do not introduce new warnings or errors
  • I have not committed any secrets, credentials, or sensitive values

Related issues

Link any issues this PR resolves or is related to.
Closes #

@GiorgosNik GiorgosNik marked this pull request as ready for review March 19, 2026 12:24
Copy link
Copy Markdown
Collaborator

@Kayle-Verhiel Kayle-Verhiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image image

The added changes look good. I additionally verified no functioanal changes happened to the updated files, good!

I am not sure we should update the input notebook files. could this result in bugs?

@GiorgosNik
Copy link
Copy Markdown
Collaborator Author

Image image
The added changes look good. I additionally verified no functioanal changes happened to the updated files, good!

I am not sure we should update the input notebook files. could this result in bugs?

I run the "new" files, and there is no issue; they complete normally. This is logical, given that this is just metadata that got cleaned through; I would not expect changes.

Copy link
Copy Markdown
Collaborator

@Kayle-Verhiel Kayle-Verhiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it myself as well and it works.

@Kayle-Verhiel Kayle-Verhiel merged commit 9fa000f into main Mar 19, 2026
18 checks passed
@GiorgosNik GiorgosNik deleted the feature/pre-commit-hooks branch March 19, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants