Adding landing page#14
Open
Himanshu-Agg12 wants to merge 1 commit intopraveenscience:mainfrom
Himanshu-Agg12:main
Open
Adding landing page#14Himanshu-Agg12 wants to merge 1 commit intopraveenscience:mainfrom Himanshu-Agg12:main
Himanshu-Agg12 wants to merge 1 commit intopraveenscience:mainfrom
Himanshu-Agg12:main
Conversation
praveenscience
requested changes
Oct 6, 2021
Owner
praveenscience
left a comment
praveenscience
left a comment
There was a problem hiding this comment.
Hi, this is great, but a concept of landing page is a profile's landing page. I would like to accept this, but can you please do the following changes:
- Indent the code with 2 spaces.
- Remove unnecessary line spaces.
- Make the HTML, CSS and JS pass the linting.
Author
|
ok, i will make changes. Thanks for review sir. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.