test: deny Cedar eval errors even when a permit fired - #39
Merged
araujof merged 3 commits intoAug 26, 2026
Conversation
Cedar still Allows if a sibling permit matched. The override must Deny with a fail-closed reason, or the gate is untrusted. Signed-off-by: mkoushni <mkoushni@redhat.com>
3 tasks
praxis-bot
reviewed
Aug 25, 2026
praxis-bot
left a comment
praxis-bot
left a comment
There was a problem hiding this comment.
Review of test for fail-closed Cedar evaluation error override.
Two findings -- both about missing assertions that the rest of this file consistently applies to every deny path.
The other deny tests in this file pin rule_source and diagnostics. Without those checks, an error-path attribution regression would pass. Signed-off-by: mkoushni <mkoushni@redhat.com>
Signed-off-by: mkoushni <mkoushni@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cedar can still Allow when a policy in the set errored, as long as another permit fired. We override that to Deny. This pins it.
One test through
evaluate(): an unconditional permit next to awhenonprincipal.department. Cedar errors, still Allows on the permit, and we have to Deny with a reason that says fail-closed and names the error.Closes #2
Test plan
cargo test -p praxis-policy-pdp-cedar-direct --test basic_allow_deny evaluation_error_denies_even_when_a_permit_fired