chore(lints): deny unused items - #44
Open
mkoushni wants to merge 2 commits into
Open
Conversation
So a function with no caller is a compile error rather than something coverage work has to find by hand. Drops remove_route_annotation and with_pdp_router, and the unused hyper crate machete reported. Signed-off-by: mkoushni <mkoushni@redhat.com>
Keep PolicyEngine::remove_route_annotation; main's reentrancy tests call it. with_pdp_router stays gone. Signed-off-by: mkoushni <mkoushni@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dead_codewas allowed, so unused functions only showed up while chasing coverage. That is the wrong way to find them. The lint is now deny.AplRouteHandler::with_pdp_routerhad no caller and is gone (0.1.x). Hosts that need several PDP dialects still pass aPdpRoutertowith_pdp.PolicyEngine::remove_route_annotationstays: main's reentrancy tests call it.Everything else that fired was deleted or kept with a reason.
make machetehad one real unused dep: a directhyperon the facade thathyper-utilalready pulls in.Closes #13
Test plan
make cimake coverage(95.29%, floor 95)make machetecleanpraxis-proxy/mainresolved;make lintandmake testafter the merge