chore: Fix mocha in Node v22+ - #4629
Merged
Merged
Conversation
JoviDeCroock
approved these changes
Jan 19, 2025
marvinhagemeister
approved these changes
Jan 20, 2025
rschristian
force-pushed
the
chore/node-22
branch
from
February 17, 2025 01:55
c8a53f9 to
f1fcf61
Compare
rschristian
marked this pull request as ready for review
February 17, 2025 01:55
Member
Author
|
As best as I can tell, this is a change in how Node tries to determine module types. Whereas in the past CJS was assumed here, Node now begins to read the file and guesses that this is meant to be ESM once it sees those As this is meant to be the assumed/default value, I'm really hoping nothing breaks here. |
Merged
This was referenced Feb 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just quick fix (that we don't need quite yet) as I noticed it.
Mocha seemingly requires an explicit
"type": "commonjs"as of Node 22+, perhaps because of the newrequire(esm)that landed? Not quite sure.This fixes it, in lieu of Mocha fixing something upstream (which they very well might do yet).