fix: Devtool flag inconsistencies #113
Conversation
src/devtools.ts
Outdated
| if (entry === id && (!config.isProduction || injectInProd)) { | ||
| const source = injectInProd ? "preact/devtools" : "preact/debug"; | ||
| if (entry === id && devToolsEnabled) { | ||
| const source = devtoolsInProd ? "preact/devtools" : "preact/debug"; |
There was a problem hiding this comment.
I don't quite understand why the source changes based upon whether devtoolsInProd is enabled or not. Is this correct? This seems wrong to me, but it's perfectly possible I'm missing something.
There was a problem hiding this comment.
During production you likely don't want the weight of preact/debug with all the warnings, just the devtools connection bridge. That's why the switch was originally introduced. The preact/devtools bridge is <200b .
There was a problem hiding this comment.
Oh shoot, I had it in my mind for some reason that devtools pulled in debug, not the other way around. Didn't even double check when confused.
My bad, cheers!
There was a problem hiding this comment.
Still, I think this is a bit of a problem as it'd mean enabling it would cause problems with dev, no?
Will correct tomorrow
There was a problem hiding this comment.
Should be correct now, will always provide 'preact/debug' in dev if devToolsEnabled is set to true/default, while in prod, you'll get 'preact/devtools' only if you've enabled devtoolsInProd.
Non-breaking form of #112
devToolsEnabledbecomes a derived value, formed of the user passed option, whether it's a prod build or not, and the user-passeddevtoolsInProdoption.Still not sure about the devtools source, see below