Core & PBS Adapter: support eventtrackers, and normalize burl / ext.prebid.events.win into it
#12711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
changed the title
burl / ext.prebid.events.win into iteventtrackers, and normalize burl / ext.prebid.events.win into it
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
2 tasks
mkomorski
approved these changes
Feb 11, 2025
patmmccann
approved these changes
Feb 19, 2025
kiho-shige
pushed a commit
to DAConsortium/Prebid.js
that referenced
this pull request
Mar 6, 2025
…ext.prebid.events.win` into it (prebid#12711) * Extract native event tracker parsing logic * ortbConverter: set response eventtrackers and translate PBS burl, events.win * fire impression trackers on billing, win trackers on render * clean up pbs wurl logic * more cleanup * rename analytics to events in markWinningBidAsUsed * lint fixes * try to appease jsdoc * add PBS test case --------- Co-authored-by: mkomorski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The PBS Adapter had special handling for two tracking URLs:
bid.burl, which was fired when a bid is deemed billable;bid.ext.prebid.events.win, fired when a bid is rendered.This allows bid responses (from any adapter) to provide an
eventtrackersarray as described in #12216:ortbConverternow movesimp.ext.eventtrackersintobidResponse.eventtrackers;ortbConvertertranslateburlinto an impression pixel andevents.wininto a "win" pixel (custom event 500), appending them toeventtrackers;markWinningBidAsUsed'sanalyticsflag is renamed toevents, and triggers both when appropriate.Other information
Closes #12698 (comment)
Closes #12216