Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: mild speedup on deepEqual #12717

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Core: mild speedup on deepEqual #12717

wants to merge 3 commits into from

Conversation

patmmccann
Copy link
Collaborator

Refactor with the same behavior. A bit faster for arrays, also avoids repeated calls to Object.keys

@patmmccann
Core: mild speedup on deepEqual
58b6d05 
a bit faster for arrays, also avoids repeated calls to Object.keys
@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • src/utils.js (+3 errors)

@patmmccann
Copy link
Collaborator Author

benchmarking in progress at https://github.com/bbaresic/util-bench

@patmmccann
Copy link
Collaborator Author

speedup stats
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@patmmccann