New user promo code #943
Open
New user promo code #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich may be discarded
…g with tests. (only checking in becuase need to check in to deal with production error.
…changed homecontroller to use service; logincontroller passes on promo code to home controller which in turn calls service; updated the view to use the custom settings for the tutorial; added and moved around integration tests to reflect and test new design
… being populated even when not in use. (Why?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After lots of little unexpected snags, finally have this fully working.
@syntheticzero Please take a look at model class InitialLoginConfiguration and set the default bookmarks and interest tags to whatever makes sense. For now, I set to ["sleep 8 hours"] and ["sleep"], respectively, but those are just placeholders. Put in the real deal and it will put into db on first use. I was going to make admin pages for this, but for now will need to manually update in the database.
Basic idea is that you can modify any of the tutorial text, bookmarks or interest tags for a given promo code. If bogus promo code provided, default will be used.
Let me know if you have any questions. Or if there are any tweaks required. Hopefully, though it is good to go.