Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

add auto-update service #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

casperdcl
Copy link

@casperdcl casperdcl commented Nov 1, 2023

add auto-update (watchtower) service

@casperdcl casperdcl self-assigned this Nov 1, 2023
@casperdcl casperdcl requested a review from tiero November 1, 2023 14:58
@casperdcl casperdcl added the enhancement New feature or request label Nov 1, 2023
@tiero
Copy link
Contributor

tiero commented Nov 1, 2023

I assume this services checks the latest tag for each docker service. This will be a huge change as we treat the versions.json as the central point for all the services to lock down their versions as the "stable" combination.

The question is (and reason for building one from scratch) it possible to programatically source the latest versions to the watchtower service?

@casperdcl
Copy link
Author

yes gewd point.

This PR would ignore versions.json, and instead use one tag (:latest) for premapp, premd, dnsd, authd, controllerd.

Note we could create a different tagging convention instead (v1, stable, etc).

AFAIK there's no way to configure watchtower to parse semver tags (i.e. to only pick major/minor/patch version updates)

@casperdcl casperdcl force-pushed the auto-update branch 3 times, most recently from f2d1392 to 0f424a1 Compare November 1, 2023 15:37
Copy link

@nsosio nsosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@filopedraz
Copy link
Contributor

LGTM, but I let @tiero decide if we can merge it.

@tiero
Copy link
Contributor

tiero commented Nov 2, 2023

Let's postpone it as enhancement after the announcement, as it involves changing something we already depend on and I am afraid many places assume versions.json as source of truth

@casperdcl casperdcl changed the title watchtower auto-update service fix & update scripts, add auto-update service Nov 2, 2023
@casperdcl
Copy link
Author

it involves changing something we already depend on

not really, auto-update is disabled by default.

@casperdcl casperdcl mentioned this pull request Nov 2, 2023
1 task
@casperdcl casperdcl changed the title fix & update scripts, add auto-update service add auto-update service Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Review
Development

Successfully merging this pull request may close these issues.

4 participants