This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
[WIP]Restart bug fix #163
Open
[WIP]Restart bug fix #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Currently we have auto_remove=True setting in here which is there cause containers are restarted in loop until correct port is find. auto_remove=True collides with newly added restart policy 'always', so looks like it wont be possible to have service restarted on machine reboot. This should be closed. |
|
Not sure always is the right way, better unless-stopped at least. Can't we attach policy to prem wervice as well? FYI services were restarted correctly not |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds restart strategy to prem-service.
Related to this
@tiero please review.