Fix for issue https://github.com/prestodb/presto-maven-plugin/issues/1 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced slash by File.separateChar
Open
|
The PR allows to build Presto on Windows because it fixes the following issue: |
|
@wanglinsong Do you think you can help here? |
wanglinsong
reviewed
Jan 18, 2023
| @@ -119,7 +119,7 @@ private List<Class<?>> findImplementationsOf(Class<?> implementationTemplate, UR | |||
| List<Class<?>> implementations = Lists.newArrayList(); | |||
| List<String> classes = FileUtils.getFileNames(classesDirectory, "**/*.class", null, false); | |||
| for (String classPath : classes) { | |||
| String className = classPath.substring(0, classPath.length() - 6).replace('/', '.'); | |||
| String className = classPath.substring(0, classPath.length() - 6).replace(File.separatorChar, '.'); | |||
There was a problem hiding this comment.
@wanglinsong No, replace should be used, because it replaces all occurrences:
public String replace(char oldChar, char newChar)
Returns a string resulting from replacing all occurrences of oldChar in this string with newChar.
while replaceAll works with regular expressions.
But I agree that it's confusing naming.
|
Thanks @wanglinsong @rongrong Do you think you can help us to merge this PR? CC @tdcmeehan |
rongrong
approved these changes
Feb 22, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced slash by File.separateChar
CheckerIntegrationTest works under Windows now
#1