Remove synchronization for updateFinalTaskInfo() #24558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During lock profiling we observed that there is some contention when calling SqlStageExecution.updateFinalTaskInfo(). runningTasks used inside this method is a thread safe hashset. Also the stateMachine.setAllTasksFinal() is thread safe, as it acquires locks before execution. So its safe to remvoe the "synchronized" for updateFinalTaskInfo().
NikhilCollooru
commented
Feb 13, 2025
| @@ -718,13 +718,13 @@ private boolean isRecoverable(List<ExecutionFailureInfo> failures) | |||
| failedTasks.size() < allTasks.size() * maxFailedTaskPercentage; | |||
| } | |||
|
|
|||
| private synchronized void updateFinalTaskInfo(TaskInfo finalTaskInfo) | |||
| private void updateFinalTaskInfo(TaskInfo finalTaskInfo) | |||
| { | |||
| runningTasks.remove(finalTaskInfo.getTaskId()); | |||
There was a problem hiding this comment.
runninTasks is a concurrent Hashset; so its thread safe.
arhimondr
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant synchronization for updateFinalTaskInfo()
Motivation and Context
During lock profiling we observed that there is some contention when calling SqlStageExecution.updateFinalTaskInfo(). runningTasks used inside this method is a thread safe hashset. Also the stateMachine.setAllTasksFinal() is thread safe, as it acquires locks before execution. So its safe to remove the "synchronized" for updateFinalTaskInfo().
Impact
None
Test Plan
Existing unit tests and verifier testing.
Contributor checklist
Release Notes